Add accessor for Binary data
#1383
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1383 +/- ##
==========================================
+ Coverage 84.65% 84.68% +0.02%
==========================================
Files 115 115
Lines 29557 29641 +84
Branches 29557 29641 +84
==========================================
+ Hits 25021 25100 +79
- Misses 3329 3330 +1
- Partials 1207 1211 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nicklan
reviewed
Oct 9, 2025
That's a good call. It does look like we need to use |
Comment on lines
+788
to
+789
| let mut visitor = BinaryVisitor { values: vec![] }; | ||
| arrow_data.visit_rows(&[ColumnName::new(["data"])], &mut visitor)?; |
There was a problem hiding this comment.
Can we also do a test where we apply BinaryVisitor on something like ints or long?
OussamaSaoudi
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Adds an accessor for Binary blobs
Resolves #1382
How was this change tested?